linux-kernel - Re: [PATCH 2/2 v2] scsi: add scsi trace core function and put trace points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B690FCD.2040405@jp.fujitsu.com>
Date:	Wed, 03 Feb 2010 14:55:25 +0900
From:	Kei Tokunaga <tokunaga.keiich@...fujitsu.com>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>
CC:	linux-scsi@...r.kernel.org,
	James Bottomley <James.Bottomley@...e.de>,
	Ingo Molnar <mingo@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Christoph Hellwig <hch@...radead.org>,
	Joe Perches <joe@...ches.com>,
	Tomohiro Kusumi <kusumi.tomohiro@...fujitsu.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Li Zefan <lizf@...fujitsu.com>,
	Xiao Guangrong <xiaoguangrong@...fujitsu.com>,
	Kei Tokunaga <tokunaga.keiich@...fujitsu.com>
Subject: Re: [PATCH 2/2 v2] scsi: add scsi trace core function and put trace
 points

Martin K. Petersen wrote:
>>>>>> "Kei" == Kei Tokunaga <tokunaga.keiich@...fujitsu.com> writes:
> 
> I'm traveling so I won't have time to look at this closely until next
> week.  However, this caught my eye:
> 
> +static const char *
> +scsi_trace_varlen(struct trace_seq *p, unsigned char *cdb, int len)
> +{
> +	switch (SERVICE_ACTION(cdb)) {
> +	case READ_32:
> +	case WRITE_32:
> +		/* if protection is enabled */
> +		if (((cdb[10] >> 5) & 0x7) == 1)
> +			return scsi_trace_rw32(p, cdb, len);
> +		/* fall through */
> +	default:
> +		return scsi_trace_misc(p, cdb, len);
> +	}
> +}
> 
> It is not a requirement that a 32-byte READ/WRITE request must have
> PROTECT set.  So that if statement is bogus.

Yes.  I agree that the if statement is not necessary here.  I'll
fix it.  Thanks for having your time for the review.

Kei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/