linux-kernel - Re: [RFC PATCH] ARM: Change the mandatory barriers implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B6A131B.1070005@codeaurora.org>
Date:	Wed, 03 Feb 2010 16:21:47 -0800
From:	Abhijeet Dharmapurikar <adharmap@...eaurora.org>
To:	Catalin Marinas <catalin.marinas@....com>
CC:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Tony Lindgren <tony@...mide.com>,
	Larry Bassel <lbassel@...cinc.com>,
	Daniel Walker <dwalker@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	linux-arm-msm@...r.kernel.org
Subject: Re: [RFC PATCH] ARM: Change the mandatory barriers implementation

> The mandatory barriers (mb, rmb, wmb) are used even on uniprocessor
> systems for things like ordering Normal Non-cacheable memory accesses
> with DMA transfer (via Device memory writes). The current implementation
> uses dmb() for mb() and friends but this is not sufficient. The DMB only
> ensures the ordering of accesses with regards to a single observer
> accessing the same memory. If a DMA transfer is started by a write to
> Device memory, the data to be transfered may not reach the main memory
> (even if mapped as Normal Non-cacheable) before the device receives the
> notification to begin the transfer. The only barrier that would help in
> this situation is DSB which would completely drain the write buffers.

On ARMv7, DMB guarantees that all accesses prior to DMB are observed by 
an observer if that observer sees any accesses _after_ the DMB. In this 
case, since DMA engine observes a write to itself( It is being written 
to and hence must observe the write) it should also see the writes to 
the buffers. A dmb() after the writes to buffer and before write to DMA 
engine should suffice.

Moreover an mb() could be in places where accesses to ARM's Device type 
memory need ordering and are 1kb apart. Such usages of mb() would result 
in a dsb() and could cause performance problems.

Since you mention the write buffers this probably applies only to ARMv6. 
Correct me here, I think that dmb on ARMv6 should suffice too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/