linux-kernel - Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1002041425050.15395@pobox.suse.cz>
Date:	Thu, 4 Feb 2010 14:27:42 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Pekka Sarnila <sarnila@...t.fi>
Cc:	Jiri Slaby <jirislaby@...il.com>, Antti Palosaari <crope@....fi>,
	mchehab@...radead.org, linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	linux-media@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes

On Thu, 4 Feb 2010, Pekka Sarnila wrote:

> The FULLSPEED thing is really not ir receiver specific problem. It can 
> happen with any device with interrupt endpoint. That's the reason why I 
> placed the quirk to HID driver.
> 
> However even the HID driver is logically a wrong place. Really it should 
> belong to the usb/endpoint layer because this really is not HID specific 
> problem but usb layer problem (as also Jiri Kosina then pointed out). 
> However linux usb layer has been build so that it was technically 
> impossible to put it there without completely redesigning usb <-> higher 
> layer (including HID) interface. But I'm of the opinion that that 
> redesign should be done anyway. Even when no quirk is needed interrupt 
> endpoint handling is a usb level task not a hid level (or any other 
> higher level) task. The usb layer should do the interrupt endpoint 
> polling and just put up interrupt events to higher layers. Partly this 
> confusion is due the poor usb/hid specifications. It really should be a 
> device/endpoint-quirk.

Yes, I still think what I have stated before, that this should be properly 
handled in the USB stack.

On the other hand, in usbhid driver we do a lot of USB-specific 
lower-level things anyway, so it's technically more-or-less OK to apply 
the quirk there as well (and that's why I have accepted it back then).

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/