linux-kernel - Re: [PATCH] radio-si470x-common: -EINVAL overwritten in si470x_vidioc_s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B6A242C.8060104@infradead.org>
Date:	Wed, 03 Feb 2010 23:34:36 -0200
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Tobias Lorenz <tobias.lorenz@....net>
CC:	Roel Kluin <roel.kluin@...il.com>, linux-media@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] radio-si470x-common: -EINVAL overwritten in si470x_vidioc_s_tuner()

Tobias Lorenz wrote:
> Hello Roel,
> 
> no, the default value of retval makes no difference to the function.
> 
> Retval is set by si470x_disconnect_check and si470x_set_register.
> After each call, retval is checked.
> There is no need to reset it passed.
> 
> The only reason, there is a default value is my static code checker, saying variables should have default values.
> Setting it to -EINVAL seems more reasonable to me than setting it 0.
> In fact the patch would bring up the warning on setting default values again.

Well, your static code checker is then broken ;)

>>  	struct si470x_device *radio = video_drvdata(file);
>> -	int retval = -EINVAL;
>> +	int retval;
>>  
>>  	/* safety checks */
>>  	retval = si470x_disconnect_check(radio);

You may just do then:

	int retval = si470x_disconnect_check(radio);

>>  	if (retval)
>>  		goto done;
>> +	retval = -EINVAL;
>>  
>>  	if (tuner->index != 0)
>>  		goto done;
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/