linux-kernel - Re: [PATCH 4/9] x86: move hp-wmi's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100204200527.GA23497@srcf.ucam.org>
Date:	Thu, 4 Feb 2010 20:05:27 +0000
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Frans Pop <elendil@...net.nl>,
	Larry Finger <Larry.Finger@...inger.net>,
	Len Brown <lenb@...nel.org>, Helge Deller <deller@....de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 4/9] x86: move hp-wmi's probe function to .devinit.text

On Thu, Feb 04, 2010 at 08:56:52PM +0100, Uwe Kleine-König wrote:
> A pointer to hp_wmi_bios_setup is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
> 
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: Frans Pop <elendil@...net.nl>
> Cc: Larry Finger <Larry.Finger@...inger.net>
> Cc: Len Brown <lenb@...nel.org>
> Cc: Helge Deller <deller@....de>
> Cc: Matthew Garrett <mjg@...hat.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>

Acked-by: Matthew Garrett <mjg@...hat.com>

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/