linux-kernel - Re: [PATCH 2/9] platform-drivers: move probe to .devinit.text in drivers/scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100204213158.GB3035@pengutronix.de>
Date:	Thu, 4 Feb 2010 22:31:58 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Dmitri Vorobiev <dmitri.vorobiev@...ial.fi>,
	Henrik Kretzschmar <henne@...htwindheim.de>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Kay Sievers <kay.sievers@...y.org>,
	peter fuerst <post@...st.de>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: Re: [PATCH 2/9] platform-drivers: move probe to .devinit.text in
	drivers/scsi

Hello,

On Thu, Feb 04, 2010 at 09:25:07PM +0100, Ralf Baechle wrote:
> On Thu, Feb 04, 2010 at 08:56:50PM +0100, Uwe Kleine-König wrote:
> 
> > A pointer to a probe callback is passed to the core via
> > platform_driver_register and so the function must not disappear when the
> > .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> > unbinding and binding a device to the driver via sysfs will result in an
> > oops as does a device being registered late.
> > 
> > An alternative to this patch is using platform_driver_probe instead of
> > platform_driver_register plus removing the pointer to the probe function
> > from the struct platform_driver.
> 
> sgiwd93 bits looks good, so
> 
> Acked-by: Ralf Baechle <ralf@...ux-mips.org>
> 
> The IP22 hardware doesn't support hotplugging so this bug isn't dangerous.
You can still trigger it via sysfs.  You need to be root though.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/