linux-kernel - Inconsistency in ioread functions, const pointer or not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <201002051145.23740.roman.fietze@telemotive.de>
Date:	Fri, 5 Feb 2010 11:45:23 +0100
From:	Roman Fietze <roman.fietze@...emotive.de>
To:	linux-kernel@...r.kernel.org
Subject: Inconsistency in ioread functions, const pointer or not

Hello,

Sorry if this subject was discussed before, but I could not find
anything except

  http://lkml.indiana.edu/hypermail/linux/kernel/0702.0/0328.html

The old ioreadx routines have been macros using the appropriate readx
functions or macros, those in turn used some raw read functions, which
finally used a memory pointer like this one:

  static inline u8 __raw_readb(const volatile void __iomem *addr)

The iomap ioreadx functions have signatures like

  extern unsigned int ioread8(void __iomem *)

I can understand the discussion about the volatile qualifier, but how
about the const?

Any pointer to discussions about removing const would be helpful.

If there are none of them, does anybody know the reason for removing
the const?

Additional question would be about the return types and target types
for the pointer, why they are int instead of e.g. u8 or void * instead
of u8 *, but probably this has to be another thread or was discussed
somewhere else.


Roman

-- 
Roman Fietze                Telemotive AG Büro Mühlhausen
Breitwiesen                              73347 Mühlhausen
Tel.: +49(0)7335/18493-45        http://www.telemotive.de
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/