linux-kernel - Re: [PATCH 04/11 v2] VT-d: Change {un}map_range functions to implement {un}map interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100205110011.GY16236@amd.com>
Date:	Fri, 5 Feb 2010 12:00:11 +0100
From:	Joerg Roedel <joerg.roedel@....com>
To:	David Woodhouse <dwmw2@...radead.org>
CC:	kvm@...r.kernel.org, Marcelo Tosatti <mtosatti@...hat.com>,
	linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
	Avi Kivity <avi@...hat.com>, Joerg Roedel <joro@...tes.org>
Subject: Re: [PATCH 04/11 v2] VT-d: Change {un}map_range functions to
 implement {un}map interface

Hi David,

On Mon, Feb 01, 2010 at 03:16:46PM +0100, Joerg Roedel wrote:
> On Fri, Jan 29, 2010 at 10:05:26AM +0100, Joerg Roedel wrote:
> > > Um, that's not a page-size based interface. Page size isn't always 4KiB;
> > > this code runs on IA64 too.
> > > 
> > > We have enough fun with CPU vs. DMA page size on IA64 already :)
> > 
> > Ah right. So this should be
> > 
> > 	size     = PAGE_SIZE << gfp_order;
> > 
> > Right? The interface is meant to map the same amount of memory which
> > alloc_pages(gfp_order) would return. Same for the return value of the
> > unmap function.
> 
> Ok, here is an updated patch (also updated in the iommu/largepage
> branch). Does it look ok to you David?

have you had a chance to look at the new version of the patch? If you
are fine with it and with the overall concept of this patchset I would
be cool if you could give your Acks. I would like to send this code to
Linus in the next merge window.

Thanks,

	Joerg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/