linux-kernel - Re: [PATCH] cciss: Make cciss_seq_show handle holes in the h->drv[] array.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100205121443.GF1025@kernel.dk>
Date:	Fri, 5 Feb 2010 13:14:43 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	"Stephen M. Cameron" <scameron@...rdog.cce.hp.com>
Cc:	akpm@...ux-foundation.org, stable@...nel.org,
	mikem@...rdog.cce.hp.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cciss: Make cciss_seq_show handle holes in the
	h->drv[] array.

On Thu, Feb 04 2010, Stephen M. Cameron wrote:
> From: Stephen M. Cameron <scameron@...rdog.cce.hp.com>
> 
> cciss: Make cciss_seq_show handle holes in the h->drv[] array.
> It is possible (and expected) for there to be holes in the h->drv[]
> array, that is, some elements may be NULL pointers.  cciss_seq_show
> needs to be made aware of this possibility to avoid an Oops.
> 
> To reproduce the Oops which this fixes:
> 
> 1) Create two "arrays" in the Array Configuratino Utility and
>    several logical drives on each array.
> 2) cat /proc/driver/cciss/cciss* in an infinite loop
> 3) delete some of the logical drives in the first "array."
> 
> Signed-off-by: Stephen M. Cameron <scameron@...rdog.cce.hp.com>

Thanks Stephen, applied for 2.6.33. BTW, you want to put that stable cc
into the patch itself as well, then it'll get picked up automatically
when Linus merges it.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/