linux-kernel - Re: [PATCH 02/11] tracing: Introduce TRACE_EVENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 05 Feb 2010 15:53:24 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	rostedt@...dmis.org
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Hitoshi Mitake <mitake@....info.waseda.ac.jp>,
	Li Zefan <lizf@...fujitsu.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Jens Axboe <jens.axboe@...cle.com>
Subject: Re: [PATCH 02/11] tracing: Introduce TRACE_EVENT_INJECT

On Fri, 2010-02-05 at 09:47 -0500, Steven Rostedt wrote:
> On Wed, 2010-02-03 at 10:14 +0100, Frederic Weisbecker wrote:
> > TRACE_EVENT_INJECT macro is the same as TRACE_EVENT but takes one
> 
> >  #undef DEFINE_EVENT
> >  #define DEFINE_EVENT(template, call, proto, args)		\
> >  static void ftrace_profile_##call(proto)			\
> > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> > index 189b09b..5c75cc7 100644
> > --- a/kernel/trace/trace_events.c
> > +++ b/kernel/trace/trace_events.c
> > @@ -142,6 +142,9 @@ static int ftrace_event_enable_disable(struct ftrace_event_call *call,
> >  				break;
> >  			}
> >  			call->enabled = 1;
> > +
> > +			if (call->inject)
> > +				call->inject();
> >  		}
> >  		break;
> >  	}
> 
> With the proposal I'm suggesting:
> 
> register_event_command(event, NULL, NULL, inject_me, inject_me, data);
> 
> The above would do basically what this patch does. When ever the event
> is enabled or disabled the inject_me function will be called.
> 
> Would this work?

No, because a dump all inject sucks chunks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/