linux-kernel - [RFC][PATCH] perf_events: Fix FORK events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1265384243.30057.42.camel@laptop>
Date:	Fri, 05 Feb 2010 16:37:23 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: [RFC][PATCH] perf_events: Fix FORK events

Hi,

While looking into a problem reported by Pekka, I noticed that I wasn't
receiving any FORK events for a workload that did fork (see attachment).

After making the below change, stuff started working again, thing is,
I'm not sure why.

The main change is sending the FORK event to the parent instead of the
child thread, however perf_event_fork() is at the end of copy_process(),
which is after perf_event_init_task() which inherits all the counters,
so it should all have worked as it was.

We could of course just slam the commit in and not worry about it, but
that just doesn't feel right.

Alternatively, I'm really really dense and I'm totally missing the
obvious.

Signed-ff-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
---
 kernel/perf_event.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index ab8a312..01655fa 100644
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -3399,8 +3399,6 @@ static void perf_event_task_output(struct perf_event *event,
 	task_event->event_id.tid = perf_event_tid(event, task);
 	task_event->event_id.ptid = perf_event_tid(event, current);
 
-	task_event->event_id.time = perf_clock();
-
 	perf_output_put(&handle, task_event->event_id);
 
 	perf_output_end(&handle);
@@ -3440,7 +3438,7 @@ static void perf_event_task_event(struct perf_task_event *task_event)
 	cpuctx = &get_cpu_var(perf_cpu_context);
 	perf_event_task_ctx(&cpuctx->ctx, task_event);
 	if (!ctx)
-		ctx = rcu_dereference(task_event->task->perf_event_ctxp);
+		ctx = rcu_dereference(current->perf_event_ctxp);
 	if (ctx)
 		perf_event_task_ctx(ctx, task_event);
 	put_cpu_var(perf_cpu_context);
@@ -3471,6 +3469,7 @@ static void perf_event_task(struct task_struct *task,
 			/* .ppid */
 			/* .tid  */
 			/* .ptid */
+			.time = perf_clock(),
 		},
 	};
 


View attachment "loop_1b_instructions-4x.c" of type "text/x-csrc" (288 bytes)