linux-kernel - Re: [PATCH 2/2] Staging: samsung-laptop: fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100205171443.GE14145@suse.de>
Date:	Fri, 5 Feb 2010 09:14:43 -0800
From:	Greg KH <gregkh@...e.de>
To:	Chihau Chau <chihau@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging: samsung-laptop: fix coding style issues

On Fri, Feb 05, 2010 at 02:11:48AM -0300, Chihau Chau wrote:
> From: Chihau Chau <chihau@...il.com>
> 
> This fixes some lines over 80 characters coding style issues
> 
> Signed-off-by: Chihau Chau <chihau@...il.com>
> ---
>  drivers/staging/samsung-laptop/samsung-laptop.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/samsung-laptop/samsung-laptop.c b/drivers/staging/samsung-laptop/samsung-laptop.c
> index 4877138..87ec773 100644
> --- a/drivers/staging/samsung-laptop/samsung-laptop.c
> +++ b/drivers/staging/samsung-laptop/samsung-laptop.c
> @@ -99,7 +99,8 @@ static struct rfkill *rfk;
>  
>  static int force;
>  module_param(force, bool, 0);
> -MODULE_PARM_DESC(force, "Disable the DMI check and forces the driver to be loaded");
> +MODULE_PARM_DESC(force, "Disable the DMI check and forces the driver to be "
> +								"loaded");

Um, care to move the whole string down one line to make it nicer to look
at?

>  static int debug;
>  module_param(debug, bool, S_IRUGO | S_IWUSR);
> @@ -370,7 +371,8 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
>  	{
>  		.ident = "N128",
>  		.matches = {
> -			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> +			DMI_MATCH(DMI_SYS_VENDOR,
> +					"SAMSUNG ELECTRONICS CO., LTD."),

Like this, what you did here was fine, can you do this above as well and
resubmit the whole thing to me so I can apply it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/