linux-kernel - Re: [46/74] net: restore ip source validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1mxzn8mj5.fsf@fess.ebiederm.org>
Date:	Fri, 05 Feb 2010 12:17:50 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Sven Joachim <svenjoac@....de>
Cc:	hadi@...erus.ca, Randolf Pohl <randolf.pohl@....de>,
	gregkh@...e.de, linux-kernel@...r.kernel.org, stable@...nel.org,
	stable-review@...nel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [46/74] net: restore ip source validation

Sven Joachim <svenjoac@....de> writes:

> On 2010-02-05 15:51 +0100, jamal wrote:
>
>> The problem is elsewhere. Here's the fix.
>>
>> --
>> diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c
>> index b6e7aae..469193c 100644
>> --- a/kernel/sysctl_check.c
>> +++ b/kernel/sysctl_check.c
>> @@ -220,6 +220,7 @@ static const struct trans_ctl_table
>> trans_net_ipv4_conf_vars_table[] = {
>>         { NET_IPV4_CONF_PROMOTE_SECONDARIES,    "promote_secondaries" },
>>         { NET_IPV4_CONF_ARP_ACCEPT,             "arp_accept" },
>>         { NET_IPV4_CONF_ARP_NOTIFY,             "arp_notify" },
>> +       { NET_IPV4_CONF_SRC_VMARK,              "src_valid_mark" },
>>         {}
>>  };
>> ---
>
> Well spotted, that fixes it.  Your mailer is broken however, it
> converted tabs into spaces, so I had to add the changed line manually.

Bah.  That DEVINET_SYSCTL_ENTRY requires having a binary sysctl
assigned, just to use as an index.

Which of course trips over all of the fine checks in sysctl_check.c to
keep people from assigning new binary sysctls by accident.

That is the only place in the kernel where he have that problem, I wonder
how much work it will be to finish untangling.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/