linux-kernel - Re: tags: include headers before source files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 05 Feb 2010 22:59:08 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: tags: include headers before source files

On 3.2.2010 17:25, Guennadi Liakhovetski wrote:
> Currently looking up a structure definition in TAGS / tags takes one to 
> one of multiple "static struct X" definitions in arch sources, which makes 
> it for many structs practically impossible to get to the required header. 
> This patch changes the order of sources being tagged to first scan 
> architecture includes, then the top-level include/ directory, and only 
> then the rest. It also takes into account, that many architectures have 
> more than one include directory, i.e., not only arch/$ARCH/include, but 
> also arch/$ARCH/mach-X/include etc.

Hi Guennadi

This is a cool idea, but there is one issue:


>  # find sources in arch/$1/include
>  find_arch_include_sources()
>  {
> -	find ${tree}arch/$1/include $ignore -name "$2" -print;
> +	include=$(find ${tree}arch/$1/ -name include -type d);
> +	archincludedir+=$include
> +	find $include $ignore -name "$2" -print;

You need to check if $include isn't empty, which it is on i386 or x86_64
(and on other archs where $ARCH != $SRCARCH). If I do a 'make cscope'
after your change, the second find statement crawls the whole filesystem.

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/