linux-kernel - Re: [PATCH 00/13] net: simplify seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100204175828.51b9e8a1.akpm@linux-foundation.org>
Date:	Thu, 4 Feb 2010 17:58:28 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	David Miller <davem@...emloft.net>,
	LKML <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 00/13] net: simplify seq_file code

On Fri, 05 Feb 2010 09:44:45 +0800 Li Zefan <lizf@...fujitsu.com> wrote:

> +struct hlist_node *seq_hlist_start(struct hlist_head *head, loff_t pos)
> +{
> +	struct hlist_node *node;
> +
> +	hlist_for_each(node, head)
> +		if (pos-- == 0)
> +			return node;
> +	return NULL;
> +}
> +EXPORT_SYMBOL(seq_hlist_start);
> +
> +struct hlist_node *seq_hlist_start_head(struct hlist_head *head, loff_t pos)
> +{
> +	if (!pos)
> +		return SEQ_START_TOKEN;
> +
> +	return seq_hlist_start(head, pos - 1);
> +}
> +EXPORT_SYMBOL(seq_hlist_start_head);
> +
> +struct hlist_node *seq_hlist_next(void *v, struct hlist_head *head,
> +				  loff_t *ppos)
> +{
> +	struct hlist_node *node = v;
> +
> +	++*ppos;
> +	if (v == SEQ_START_TOKEN)
> +		return head->first;
> +	else
> +		return node->next;
> +}
> +EXPORT_SYMBOL(seq_hlist_next);

Oy.  Most of the global functions in seq_file.c are kerneldocumented,
as they should be!

Shouldn't seq_hlist_start_head() have been called seq_hlist_prev()?

Should seq_hlist_start() be passed *ppos, and update *ppos so the
caller can then call seq_hlist_next() and seq_hlist_prev()?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/