linux-kernel - Re: [PATCH] obsolete config in kernel source (USB_GADGET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1002080950330.1809-100000@iolanthe.rowland.org>
Date:	Mon, 8 Feb 2010 09:51:33 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Christoph Egger <siccegge@...d.informatik.uni-erlangen.de>
cc:	linux-kernel@...r.kernel.org, <dbrownell@...rs.sourceforge.net>,
	<linux-usb@...r.kernel.org>, <vamos@...informatik.uni-erlangen.de>
Subject: Re: [PATCH] obsolete config in kernel source (USB_GADGET_*)

On Fri, 5 Feb 2010, Christoph Egger wrote:

> On Fri, Jan 15, 2010 at 09:46:00AM -0500, Alan Stern wrote:
> > On Fri, 15 Jan 2010, Christoph Egger wrote:
> > > 	The linux tree contains USB-Id assignment snippets for some
> > > USB Gadget drivers, which, as far as I can tell, never worked on
> > > mainline linux2.6 but either originate from seemingly long-dead
> > > third-party trees or were never ported from linux2.4.
> > > 
> > > 	As there has also seemingly never existed a way to select
> > > these configs in the KConfig system it might be time to get rid of
> > > them which would be done by the attached patch.
> > 
> > Have you tried building g_file_storage and the other gadget drivers 
> > after applying your patch?
> 
> 	You're right. I ony checked whether the first few were still
> needed somewhere in code and assumed equal status for all of
> them. SHould have at least build-tested all that stuff before sending
> (and doing so now).
> 
> 	Below is a updated patch that should be more correct and does
> also build (tested against mainline git).

The new patch looks okay to me.  Other people might have opinions about 
whether this code should be removed, however.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/