linux-kernel - Re: [RFC][PATCH] perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1265644666.11509.5.camel@laptop>
Date:	Mon, 08 Feb 2010 16:57:46 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Paul Mackerras <paulus@...ba.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC][PATCH] perf_events: Fix FORK events

On Mon, 2010-02-08 at 08:44 +0100, Ingo Molnar wrote:
> 
> > We could of course just slam the commit in and not worry about it, but
> > that just doesn't feel right.
> 
> Would be nice to figure it out ... 

OK, so it is real simple, patch 22e19085 ("perf: Honour event state for
aux stream data") drops all events for !ACTIVE and newly inherited child
counters are INACTIVE.

So we can either go with the original patch and send the FORK events to
the parent because that's always ACTIVE (already true for COMM and
MMAP), or weaken the state test to < INACTIVE, which would also satisfy
Anton's case because PERF_EVENT_IOC_DISABLE sets events to OFF.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/