linux-kernel - Re: [PATCH 11/11] fs/xfs: Correct NULL test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Feb 2010 14:37:26 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Julia Lawall <julia@...u.dk>
Cc:	Alex Elder <aelder@....com>, xfs-masters@....sgi.com,
	xfs@....sgi.com, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 11/11] fs/xfs: Correct NULL test

On Sat, Feb 06, 2010 at 09:45:15AM +0100, Julia Lawall wrote:
> diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c
> index 11cfd82..4318cd5 100644
> --- a/fs/xfs/quota/xfs_qm.c
> +++ b/fs/xfs/quota/xfs_qm.c
> @@ -123,7 +123,7 @@ xfs_Gqm_init(void)
>  		goto out;
>  
>  	gdqhash = kmem_zalloc_large(hsize);
> -	if (!udqhash)
> +	if (!gdqhash)
>  		goto out_free_udqhash;

Thanks, this looks correct,


Reviewed-by: Christoph Hellwig <hch@....de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/