linux-kernel - Re: [PATCH] security/smack/smack.h: Fix smk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1002090827330.1779@tundra.namei.org>
Date:	Tue, 9 Feb 2010 08:28:33 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	wzt wzt <wzt.wzt@...il.com>
cc:	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH] security/smack/smack.h: Fix smk_known length

(note: please copy security/ patches to the LSM list, cc'd, along with the 
Smack maintainer).


On Mon, 8 Feb 2010, wzt wzt wrote:

> in security/smack/smack.h:
> struct smack_known {
>         struct list_head        list;
>         char                    smk_known[SMK_LABELLEN];
> but in security/smack/smack_access.c
> void smack_from_cipso(u32 level, char *cp, char *result)
> {
>         strncpy(result, final, SMK_MAXLEN);
> }
> miss '\0'.
> 
> Signed-off-by: wzt <wzt.wzt@...il.com>
> Cc: Jmorris <jmorris@...ei.org>
> 
> diff --git a/security/smack/smack.h b/security/smack/smack.h
> index c6e9aca..600474b 100644
> --- a/security/smack/smack.h
> +++ b/security/smack/smack.h
> @@ -109,7 +109,7 @@ struct smk_netlbladdr {
>   */
>  struct smack_known {
>         struct list_head        list;
> -       char                    smk_known[SMK_LABELLEN];
> +       char                    smk_known[SMK_LABELLEN + 1]; /*
> smk_known + \0 */
>         u32                     smk_secid;
>         struct smack_cipso      *smk_cipso;
>         spinlock_t              smk_cipsolock; /* for changing cipso map */
> 

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/