linux-kernel - Re: [PATCH] drivers/usb: Convert concatenated __FILE__ to %s, __FILE_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1265669231.2135.12.camel@Joe-Laptop.home>
Date:	Mon, 08 Feb 2010 14:47:11 -0800
From:	Joe Perches <joe@...ches.com>
To:	Greg KH <greg@...ah.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-usb <linux-usb@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/usb: Convert concatenated __FILE__ to %s,
 __FILE__

On Sun, 2010-02-07 at 20:49 -0800, Greg KH wrote:
> On Fri, Feb 05, 2010 at 05:51:13PM -0800, Joe Perches wrote:
> > Reduces string space a bit
> It does?  Does gcc optimize all of the __FILE__ instances to point to
> the same place in the object?

Yes, just like any other duplicated const string.

Converting a source unit with a single use of __FILE__
wastes space (direct string vs pointer + "%s" + string)

Multiple conversions generally save space.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/