linux-kernel - Re: [PATCH] iwmc3200wifi: Test of wrong pointer after kzalloc in iwm_mlme_update_bss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1265716545.2236.4.camel@caravaggio>
Date:	Tue, 09 Feb 2010 12:55:45 +0100
From:	Samuel Ortiz <samuel@...tiz.org>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Samuel Ortiz <samuel.ortiz@...el.com>, Zhu Yi <yi.zhu@...el.com>,
	Intel Linux Wireless <ilw@...ux.intel.com>,
	linux-wireless@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iwmc3200wifi: Test of wrong pointer after kzalloc in
 iwm_mlme_update_bss_table()

On Tue, 2010-02-09 at 12:07 +0100, Roel Kluin wrote:
> The wrong pointer was tested.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
Acked-by: Samuel Ortiz <sameo@...ux.intel.com>


> ---
>  drivers/net/wireless/iwmc3200wifi/rx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwmc3200wifi/rx.c b/drivers/net/wireless/iwmc3200wifi/rx.c
> index 6d6ed74..f727b4a 100644
> --- a/drivers/net/wireless/iwmc3200wifi/rx.c
> +++ b/drivers/net/wireless/iwmc3200wifi/rx.c
> @@ -794,7 +794,7 @@ static int iwm_mlme_update_bss_table(struct iwm_priv *iwm, u8 *buf,
>  	}
>  
>  	bss->bss = kzalloc(bss_len, GFP_KERNEL);
> -	if (!bss) {
> +	if (!bss->bss) {
>  		kfree(bss);
>  		IWM_ERR(iwm, "Couldn't allocate bss\n");
>  		return -ENOMEM;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/