linux-kernel - Re: [PATCH 17/35] sparsemem: put mem map for one node together.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100209122127.7a33cd24.akpm@linux-foundation.org>
Date:	Tue, 9 Feb 2010 12:21:27 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 17/35] sparsemem: put mem map for one node together.

On Tue, 09 Feb 2010 11:32:28 -0800
Yinghai Lu <yinghai@...nel.org> wrote:

> +#ifdef CONFIG_NO_BOOTMEM
> +		free_early(__pa(vmemmap_buf_start), __pa(vmemmap_buf_end));
> +		if (vmemmap_buf_start < vmemmap_buf) {
> +			char name[15];
> +
> +			memset(name, 0, sizeof(name));

Is the memset actually needed?

> +			snprintf(name, 15, "MEMMAP %d", nodeid);

s/15/sizeof(name)/

> +			reserve_early_without_check(__pa(vmemmap_buf_start),
> +						    __pa(vmemmap_buf), name);
> +		}
> +#else
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/