linux-kernel - [PATCH] dvb: l64781.ko broken with gcc 4.5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100209231603.GA22588@kroah.com>
Date:	Tue, 9 Feb 2010 15:16:03 -0800
From:	Greg KH <gregkh@...e.de>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>
Cc:	Matthias Schwarzott <zzam@...too.org>,
	Douglas Schilling Landgraf <dougsland@...hat.com>,
	Andreas Oberritter <obi@...uxtv.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andreas Gruenbacher <agruen@...e.de>
Subject: [PATCH] dvb: l64781.ko broken with gcc 4.5

From: Richard Guenther <rguenther@...e.de>

I'm trying to fix it on the GCC side (PR43007), but the module is
quite stupid in using ULL constants to operate on u32 values:

static int apply_frontend_param (struct dvb_frontend* fe, struct
dvb_frontend_parameters *param)
{
...
 static const u32 ppm = 8000;
 u32 spi_bias;
...

 spi_bias *= 1000ULL;
 spi_bias /= 1000ULL + ppm/1000;


which causes current GCC 4.5 to emit calls to __udivdi3 for i?86 again.

This patch fixes this issue.

Signed-off-by: Richard Guenther <rguenther@...e.de>
Cc: Andreas Gruenbacher <agruen@...e.de>
Cc: stable <stable@...nel.org>
Cc: Mauro Carvalho Chehab <mchehab@...radead.org>
Cc: Matthias Schwarzott <zzam@...too.org>
Cc: Douglas Schilling Landgraf <dougsland@...hat.com>
Cc: Andreas Oberritter <obi@...uxtv.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>

---
 drivers/media/dvb/frontends/l64781.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/media/dvb/frontends/l64781.c
+++ b/drivers/media/dvb/frontends/l64781.c
@@ -192,8 +192,8 @@ static int apply_frontend_param (struct
 	spi_bias *= qam_tab[p->constellation];
 	spi_bias /= p->code_rate_HP + 1;
 	spi_bias /= (guard_tab[p->guard_interval] + 32);
-	spi_bias *= 1000ULL;
-	spi_bias /= 1000ULL + ppm/1000;
+	spi_bias *= 1000;
+	spi_bias /= 1000 + ppm/1000;
 	spi_bias *= p->code_rate_HP;
 
 	val0x04 = (p->transmission_mode << 2) | p->guard_interval;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/