linux-kernel - Re: [PATCH] fs: nfsd: export: fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Feb 2010 21:36:43 -0800
From:	Arjan van de Ven <arjan@...radead.org>
To:	chihau Chau <chihau@...il.com>
Cc:	bfields@...ldses.org, neilb@...e.de, viro@...iv.linux.org.uk,
	Trond.Myklebust@...app.com, bharrosh@...asas.com,
	akpm@...ux-foundation.org, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, Chihau Chau <chihau@...il.com>
Subject: Re: [PATCH] fs: nfsd: export: fix coding style issues

> -static struct svc_expkey *svc_expkey_update(struct svc_expkey *new, struct svc_expkey *old); 
> +static struct svc_expkey *svc_expkey_update(struct svc_expkey *new,
> +							struct svc_expkey *old); 


how is this an improvement ? I don't find the 2nd more more readable

also, are you planning to do real changes to this file? If not, I would suggest not doing cleanups like this;
while cleanups like the other things you did are fine as a first step to doing real work on a file, it's usually
not liked very much to ONLY do such cosmetic things...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/