linux-kernel - Re: [PATCH] thinkpad-acpi: setup hotkey polling after changing hotkey_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100208162153.b317e434.akpm@linux-foundation.org>
Date:	Mon, 8 Feb 2010 16:21:53 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
Cc:	linux-acpi@...r.kernel.org,
	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	ibm-acpi-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thinkpad-acpi: setup hotkey polling after changing
 hotkey_driver_mask

On Mon, 8 Feb 2010 22:08:10 -0200
Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com> wrote:

>
> ...
>
> > --- a/drivers/platform/x86/thinkpad_acpi.c~thinkpad-acpi-setup-hotkey-polling-after-changing-hotkey_driver_mask-fix
> > +++ a/drivers/platform/x86/thinkpad_acpi.c
> > @@ -2597,6 +2597,10 @@ static void hotkey_poll_set_freq(unsigne
> >  
> >  #else /* CONFIG_THINKPAD_ACPI_HOTKEY_POLL */
> >  
> > +static void hotkey_poll_setup(bool __unused)
> > +{
> > +}
> > +
> >  static void hotkey_poll_setup_safe(bool __unused)
> >  {
> >  }
> > @@ -2694,9 +2698,7 @@ static ssize_t hotkey_mask_store(struct 
> >  
> >  	res = hotkey_user_mask_set(t);
> >  
> > -#ifdef CONFIG_THINKPAD_ACPI_HOTKEY_POLL
> >  	hotkey_poll_setup(true);
> > -#endif
> >  
> >  	mutex_unlock(&hotkey_mutex);
> >  
> > @@ -6273,9 +6275,7 @@ static int __init brightness_init(struct
> >  				| TP_ACPI_HKEY_BRGHTUP_MASK
> >  				| TP_ACPI_HKEY_BRGHTDWN_MASK);;
> >  
> > -#ifdef CONFIG_THINKPAD_ACPI_HOTKEY_POLL
> > -	hotkey_poll_setup(true);
> > -#endif
> > +	hotkey_poll_setup_safe(true);
> >  
> >  	return 0;
> >  }
> > _
> > 
> 
> How about the added call to volume_init?
> 

I don't know what you mean.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/