linux-kernel - m68knommu: duplicate _ramvec[vba+CPMVEC_RISCTIMER] assignment in init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Feb 2010 15:10:17 +0100
From:	Roel Kluin <roel.kluin@...il.com>
To:	Greg Ungerer <gerg@...inux.org>, uclinux-dev@...inux.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: m68knommu: duplicate _ramvec[vba+CPMVEC_RISCTIMER] assignment in
 init_IRQ()

Hi,

Looking at arch/m68knommu/platform/68360/ints.c I noted two things that
stood out:

1) on line 110:

_ramvec[vba+CPMVEC_RISCTIMER]   = inthandler;  /* reserved */

and 114:

_ramvec[vba+CPMVEC_RISCTIMER]   = inthandler;  /* timer table */

The same definitions are used, and in the first case the comment and
definition do not correspond.

2) while all other definitions are used like this:

_ramvec[vba+CPMVEC_DEF2]   = inthandler;
...
_ramvec[vba+CPMVEC_DEF1]   = inthandler;

This is not true for CPMVEC_RESERVED:

_ramvec[vba+CPMVEC_RESERVED1]   = inthandler;   /* reserved */
...
_ramvec[vba+CPMVEC_RESERVED2]   = inthandler;  /* reserved */

Is this a bug?

Roel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/