linux-kernel - Re: [patch v2 3/4] x86, ptrace: prepare regset get/set routines for user specified lengths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100210013224.DC3441C5@magilla.sf.frob.com>
Date:	Tue,  9 Feb 2010 17:32:24 -0800 (PST)
From:	Roland McGrath <roland@...hat.com>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	Oleg Nesterov <oleg@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>, hjl.tools@...il.com
Subject: Re: [patch v2 3/4] x86, ptrace: prepare regset get/set routines for user specified lengths

This change is unnecessary and IMHO misguided.  The arch user_regset.get
and user_regset.set functions are not required to worry about bogus
arguments.  Their callers are required to pass values that don't violate
the .n, .size, and .align constraints in the user_regset.  The right place
to enforce these constraints on parameters coming from userland is in the
arch-independent code that calls the arch user_regset functions.

Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/