| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Feb 2010 13:22:01 -0800 (PST) From: David Miller <davem@...emloft.net> To: maximlevitsky@...il.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, maxim-levitsky@...il.com Subject: Re: [PATCH 2/6] DMFE: move pci ID definitions into pci_ids.h and clean up the code From: David Miller <davem@...emloft.net> Date: Wed, 10 Feb 2010 13:18:49 -0800 (PST) > From: Maxim Levitsky <maximlevitsky@...il.com> > Date: Sat, 6 Feb 2010 22:18:58 +0200 > >> Signed-off-by: Maxim Levitsky <maxim-levitsky@...il.com> > > We don't add new definitions to pci_ids.h that will only > be used in a single driver. > > Instead, we just use the raw constants (if it's only referenced once, > say in the PCI ID table for the driver) or using local definitions > (if used multiple times in the driver). BTW, the rest of your patch set is likely to not apply correctly after you fix this patch up. So at a minimum you'll need to resubmit this whole set after fixing patch #2. In fact I would recommend that you seperate the bug fixes from all of the massive cleanups. Get the bug fixes, especially the PCI READ MULTIPLE disable one, into net-2.6 Then afterwards you can do all of the cleanups against net-next-2.6 when the bug fixes propagate there. Thank you! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists