linux-kernel - Re: [PATCH 5/6] syscalls: add define syscall prefix macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1265770813.24386.48.camel@gandalf.stny.rr.com>
Date:	Tue, 09 Feb 2010 22:00:13 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jason Baron <jbaron@...hat.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux-kernel@...r.kernel.org, laijs@...fujitsu.com,
	lizf@...fujitsu.com, fweisbec@...il.com, mingo@...e.hu,
	hpa@...or.com, tglx@...utronix.de, mhiramat@...hat.com
Subject: Re: [PATCH 5/6] syscalls: add define syscall prefix macro

On Mon, 2010-02-08 at 12:11 -0500, Jason Baron wrote:

> Most of the copat syscall are currently not using the 'SYCALL_DEFINE()'
> family of macros. For my purposes, the use of these macros allows them
> to be tied into the event tracing system. These macros append 'sys_' to
> the begging of the system call name. However, for compat syscall which
> are named 'sys32_blah', these macros are not sufficient. Thus, the need
> to introduce some new macros for the compat syscalls. 
> 
> > The added level of indirection makes problems for scripts/kernel-doc (well, if any of
> > the syscalls have kernel-doc notation, that is).  I'd prefer not to see 2 levels of macros
> > for defining a syscall, but if it has to live, please look into updating scripts/kernel-doc
> > also.
> > 
> 
> good point. I'll make sure the docs work properly.

Could you also make sure 'make TAGS' is updated too.
See scripts/tags.sh and search for SYSCALL

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/