linux-kernel - Re: [PATCH] sysfs: differentiate between locking links and non-links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2375c9f91002091933t3add9e19ydb62b85c61718f95@mail.gmail.com>
Date:	Wed, 10 Feb 2010 11:33:53 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Neil Brown <neilb@...e.de>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Tejun Heo <tj@...nel.org>, Greg Kroah-Hartman <gregkh@...e.de>,
	Hugh Dickins <hugh.dickins@...cali.co.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sysfs: differentiate between locking links and non-links

On Wed, Feb 10, 2010 at 11:19 AM, David Rientjes <rientjes@...gle.com> wrote:
> On Wed, 10 Feb 2010, Américo Wang wrote:
>
>> > You should be able to reuse Neil's sysfs_dirent_init_lockdep(sd, type) to
>> > seperate the lock classes for the sd getting pinned in
>> > sysfs_get_active_two() from sysfs_deactivate(), although using subclasses
>> > would probably be optimal since there is a clear parent -> child relationship.
>>
>> Yeah, basically, my fix is also adding a separate lockdep class, but
>> at a different
>> level. I will send the fix as soon as I finish it.
>>
>
> They shouldn't be entirely seperate classes for your "mutable" cases since
> there will always be a parent -> child relationship, they should be
> subclasses under the same lockclass at a SINGLE_DEPTH_NESTING level.

The relationship is not always clear, take the cpu hotplug case as an example,
there are plenty of sysfs files will be removed if we take one cpu
offline, like mce
files, which are not even under the same directory with cpu sysfs
device directory.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/