linux-kernel - Re: [fuse-devel] [PATCH] FUSE/CUSE: implement direct mmap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Feb 2010 14:01:23 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Tejun Heo <tj@...nel.org>
CC:	miklos@...redi.hu, mszeredi@...e.cz, linux-kernel@...r.kernel.org,
	fuse-devel@...ts.sourceforge.net, polynomial-c@...too.org,
	akpm@...ux-foundation.org
Subject: Re: [fuse-devel] [PATCH] FUSE/CUSE: implement direct mmap support

On Thu, 11 Feb 2010, Tejun Heo wrote:
> > And playing with ->vm_pgoff is *not* a valid thing to do for the
> > client, at least not on "normal" mmaps.
> 
> That's the requirement coming from allowing the server to determine
> how these mmaps are served, not from the fact that the management is
> done via server side mmaps or the server maps those regions into its
> process address space.  No matter how you do it, if you want to mix
> and match client mmap requests, the SHMLBA alignment will be visible.

Can you give an example?

> I suppose you're talking about not allowing offsets to be adjusted at
> all but I don't think that's a restriction we would want to have at
> the kernel API level because offset might encode different things for
> device mmaps.

Possibly.  But there's some confusion about offsets again.  This
offset is not the same as the one currently returned in fuse_mmap_out.

And neither is the SHMLBA alignment requirement so clear:

You say, that ossp ignores the client mmap offset.  So basically it
resets the offset to zero, whatever it was, no?  That sounds fine, but
then you are adjusting the offset by something not necessarily a
multiple of SHMLBA.

So there are different offsets:

 a) vma->vm_pgoff (which may mean anything, but usually means b)
 b) the offset at which the pages of the mapping are located
 c) the offset at which the server side mmap is located

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/