lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 11 Feb 2010 15:55:56 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: devres/irq: Fix cross-referencing comments

On Thu, 11 Feb 2010, Jean Delvare wrote:

> Fix the reference (in comment) from devm_request_irq to devm_free_irq
> and back.
> 
> Signed-off-by: Jean Delvare <khali@...ux-fr.org>
> ---
>  kernel/irq/devres.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-2.6.33-rc7.orig/kernel/irq/devres.c	2009-06-10 05:05:27.000000000 +0200
> +++ linux-2.6.33-rc7/kernel/irq/devres.c	2010-02-11 14:53:35.000000000 +0100
> @@ -42,7 +42,7 @@ static int devm_irq_match(struct device
>   *	automatically freed on driver detach.
>   *
>   *	If an IRQ allocated with this function needs to be freed
> - *	separately, dev_free_irq() must be used.
> + *	separately, devm_free_irq() must be used.
>   */
>  int devm_request_threaded_irq(struct device *dev, unsigned int irq,
>  			      irq_handler_t handler, irq_handler_t thread_fn,
> @@ -81,7 +81,7 @@ EXPORT_SYMBOL(devm_request_threaded_irq)
>   *	Except for the extra @dev argument, this function takes the
>   *	same arguments and performs the same function as free_irq().
>   *	This function instead of free_irq() should be used to manually
> - *	free IRQs allocated with dev_request_irq().
> + *	free IRQs allocated with devm_request_irq().
>   */
>  void devm_free_irq(struct device *dev, unsigned int irq, void *dev_id)
>  {

Hi Jean,

the latter has already been fixed in my tree. Applied the former hunk. 
Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ