linux-kernel - Re: linux-next: build warning after merge of the suspend tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1002111029440.1571-100000@iolanthe.rowland.org>
Date:	Thu, 11 Feb 2010 10:32:08 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	<linux-next@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the suspend tree

On Thu, 11 Feb 2010, Rafael J. Wysocki wrote:

> On Thursday 11 February 2010, Stephen Rothwell wrote:
> > Hi Rafael,
> > 
> > After merging the suspend tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > drivers/usb/core/hcd-pci.c:138: warning: 'wait_for_companions' defined but not used
> > 
> > Introduced by commit ce74abf51a15ab82a9fae6dcd8a9c0038945f10e ("USB:
> > implement non-tree resume ordering constraints for PCI host controllers").
> 
> Thanks for the info, I'll fix this up later today in my tree.

Clearly wait_for_companions() needs to be inside "#ifdef
CONFIG_PM_SLEEP ... #endif".  In fact, all the new functions added by
the patch should be protected this way, with suitable do-nothing inline
versions provided when CONFIG_PM_SLEEP isn't defined.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/