linux-kernel - Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in pohmelfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100211171018.GR30031@ZenIV.linux.org.uk>
Date:	Thu, 11 Feb 2010 17:10:18 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Evgeniy Polyakov <zbr@...emap.net>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in
 pohmelfs

On Thu, Feb 11, 2010 at 06:08:05PM +0300, Evgeniy Polyakov wrote:
> On Thu, Feb 11, 2010 at 03:02:54AM +0000, Al Viro (viro@...IV.linux.org.uk) wrote:
> > Um.  You do realize that d_move() happens with none of your locks held,
> > right?  It's done in vfs_rename_{other,dir}() and the only thing held
> > is s_vfs_rename_sem and i_mutex on parents.  How could your code in
> > writeback be able to distinguish
> 
> No, it happens with my lock held. It is not a lock, but kind of
> IO delegation, i.e. it is not dropped when rename or other protected
> operation completed. Instead another client sends request to grab it and
> server asks current holder to drop cache, perform writeback or whatever
> else is needed.

And should such a request come between return from ->rename() and call
of d_move() that follows it?

> It can be a problem though if d_move() is called outside of path
> protected by the VFS dir operations like rename/created/unlink and so
> on, i.e. on behalf of some entity in the kernel which decides to move
> dentries on itself. In this case POHMELFS is not protected.

Not an issue; there's no such fs-independent callers.

Fundamentally, how do you deal with MOESI when the mapping from strings you
are using as object IDs to actual objects can change as the result of
operations?  What's more, operation on one object can change that mapping
for a huge number of other objects (rename() close to fs root changing
pathnames of all files anywhere in the subtree being moved).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/