linux-kernel - Re: [PATCH] Add Dell Business Class Netbook LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100211180715.GA2147@srcf.ucam.org>
Date:	Thu, 11 Feb 2010 18:07:15 +0000
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	Bob Rodgers <Robert_Rodgers@...l.com>,
	"lenb@...nel.org" <lenb@...nel.org>,
	Linux-kernel <linux-kernel@...r.kernel.org>,
	Louis Davis <Louis_Davis@...l.com>,
	Jim Dailey <Jim_Dailey@...l.com>,
	Michael Brown <Michael_E_Brown@...l.com>,
	Mario Limonciello <Mario_Limonciello@...l.com>,
	Matt Domsch <Matt_Domsch@...l.com>,
	Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH] Add Dell Business Class Netbook LED driver

On Thu, Feb 11, 2010 at 10:05:19AM -0800, Dmitry Torokhov wrote:

> Or stuck it in dell-wmi.c...

I'd prefer not to put it in dell-wmi. There's no logical association 
between it and the rest of the code there, so it'd just be overhead on 
the majority of systems. With the exception of cases where the event and 
functional interfaces are different GUIDs, I'd prefer a one GUID per 
driver model.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/