linux-kernel - Re: [PATCH] Add Dell Business Class Netbook LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100211183103.GB2605@srcf.ucam.org>
Date:	Thu, 11 Feb 2010 18:31:03 +0000
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	Bob Rodgers <Robert_Rodgers@...l.com>,
	"lenb@...nel.org" <lenb@...nel.org>,
	Linux-kernel <linux-kernel@...r.kernel.org>,
	Louis Davis <Louis_Davis@...l.com>,
	Jim Dailey <Jim_Dailey@...l.com>,
	Michael Brown <Michael_E_Brown@...l.com>,
	Mario Limonciello <Mario_Limonciello@...l.com>,
	Matt Domsch <Matt_Domsch@...l.com>,
	Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH] Add Dell Business Class Netbook LED driver

On Thu, Feb 11, 2010 at 10:28:30AM -0800, Dmitry Torokhov wrote:

> This is an opposite direction form the rest of the platform drivers
> which tend to combine functionality on per-vendor basis in one driver.

I don't think that's true - we /tend/ to see one driver per ACPI device 
or device interface (see the dell-wmi/dell-laptop split, for instance).

> I'd say that in this case with this LED driver overhead on DELL systems
> not supportinfg it is miniscule. The benefit is that all vendor-specific
> sub-devices are children of one parent platform device.

I really don't see that as a strong benefit.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/