linux-kernel - Re: [PATCH] [1/4] SLAB: Handle node-not-up case in fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1002111338090.8809@chino.kir.corp.google.com>
Date:	Thu, 11 Feb 2010 13:41:53 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Andi Kleen <andi@...stfloor.org>
cc:	penberg@...helsinki.fi, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, haicheng.li@...el.com
Subject: Re: [PATCH] [1/4] SLAB: Handle node-not-up case in fallback_alloc()
 v2

On Thu, 11 Feb 2010, Andi Kleen wrote:

> When fallback_alloc() runs the node of the CPU might not be initialized yet.
> Handle this case by allocating in another node.
> 
> v2: Try to allocate from all nodes (David Rientjes)
> 

You don't need to specifically address the cpuset restriction in 
fallback_alloc() since kmem_getpages() will return NULL whenever a zone is 
tried from an unallowed node, I just thought it was a faster optimization 
considering you (i) would operate over a nodemask and not the entire 
zonelist, (ii) it would avoid the zone_to_nid() for all zones since you 
already did a zonelist iteration in this function, and (iii) it wouldn't 
needlessly call kmem_getpages() for unallowed nodes.

> Signed-off-by: Andi Kleen <ak@...ux.intel.com>

That said, I don't want to see this fix go unmerged since you already 
declined to make that optimization once:

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/