linux-kernel - Re: [PATCH 1/1] DVB: ngene, fix memset parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201002110520.55301@orion.escape-edv.de>
Date:	Thu, 11 Feb 2010 05:20:50 +0100
From:	Oliver Endriss <o.endriss@....de>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	mchehab@...hat.com, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, jirislaby@...il.com,
	Matthias Benesch <twoof7@...enet.de>,
	Ralph Metzler <rjkm@...zlerbros.de>
Subject: Re: [PATCH 1/1] DVB: ngene, fix memset parameters

Jiri Slaby wrote:
> Switch second and third memset parameter to stamp the length buffer bytes
> by 0xff's, not 255 bytes by low 8 bits of Length.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Matthias Benesch <twoof7@...enet.de>
> Cc: Ralph Metzler <rjkm@...zlerbros.de>
> Cc: Oliver Endriss <o.endriss@....de>
> Cc: Mauro Carvalho Chehab <mchehab@...hat.com>
> ---
>  drivers/media/dvb/ngene/ngene-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
> index cb5982e..0150dfe 100644
> --- a/drivers/media/dvb/ngene/ngene-core.c
> +++ b/drivers/media/dvb/ngene/ngene-core.c
> @@ -564,7 +564,7 @@ static void FillTSBuffer(void *Buffer, int Length, u32 Flags)
>  {
>  	u32 *ptr = Buffer;
>  
> -	memset(Buffer, Length, 0xff);
> +	memset(Buffer, 0xff, Length);
>  	while (Length > 0) {
>  		if (Flags & DF_SWAP32)
>  			*ptr = 0x471FFF10;
> -- 
> 1.6.6.1

Acked-by: Oliver Endriss <o.endriss@....de>

CU
Oliver

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/
Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/
----------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/