linux-kernel - Re: [rtc-linux] [PATCH RESEND] rtc/hctosys: only claim the RTC provided the system time if it did

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100212085231.GA21947@pengutronix.de>
Date:	Fri, 12 Feb 2010 09:52:31 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, Paul Gortmaker <p_gortmaker@...oo.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [rtc-linux] [PATCH RESEND] rtc/hctosys: only claim the RTC
	provided  the system time if it did

Hello Andrew,

On Thu, Feb 11, 2010 at 02:42:40PM -0800, Andrew Morton wrote:
> On Thu, 11 Feb 2010 11:57:00 +0100
> Alessandro Zummo <a.zummo@...ertech.it> wrote:
> 
> > On Thu, 11 Feb 2010 11:52:29 +0100
> > Uwe Kleine-K__nig <u.kleine-koenig@...gutronix.de> wrote:
> > 
> > 
> > > Signed-off-by: Uwe Kleine-K__nig <u.kleine-koenig@...gutronix.de>
> > > ---
> > > Hello,
> > > 
> > > this time the patch is complete.
> > > 
> > > What do you think about it?
> 
> I do dislike having to trawl through the patch trying to work out what
> the changelog forgot to tell me.
> 
> What problem is being fixed here?
> 
> What is the user-observable manifestation of that problem?
> 
> How does the patch fix it?
> 
> Stuff like that!
What do you think about:

---->8----
rtc/hctosys: only claim the RTC provided the system time if it did

Without this patch /sys/class/rtc/$CONFIG_RTC_HCTOSYS_DEVICE/hctosys
contains a 1 (meaning "This rtc was used to initialize the system
clock") even if reading the time at bootup failed.

Moreover change error handling in rtc_hctosys() to use goto and so
reduce the indention level.
---->8----

> >  looks nice but I'll have to give a deeper look.
> >  will probably queue for the next merge window
> 
> I merged it with a "needs Alessandro ack" note-to-self.
fine, thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/