linux-kernel - Re: [PATCH 1/2] ARM: ixp2000: fix type of ixp2000_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100212104947.GB6590@pengutronix.de>
Date:	Fri, 12 Feb 2010 11:49:47 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Russell King <linux@....linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: ixp2000: fix type of ixp2000_timer_interrupt

Hi Russell,

On Sat, Jan 23, 2010 at 10:01:39PM +0100, Uwe Kleine-König wrote:
> This fixes a build warning for 2.6.33-rc5:
> 
> 	arch/arm/mach-ixp2000/core.c:217: warning: initialization from incompatible pointer type
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  arch/arm/mach-ixp2000/core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-ixp2000/core.c b/arch/arm/mach-ixp2000/core.c
> index babb225..e24e3d0 100644
> --- a/arch/arm/mach-ixp2000/core.c
> +++ b/arch/arm/mach-ixp2000/core.c
> @@ -197,7 +197,7 @@ unsigned long ixp2000_gettimeoffset (void)
>  	return offset / ticks_per_usec;
>  }
>  
> -static int ixp2000_timer_interrupt(int irq, void *dev_id)
> +static irqreturn_t ixp2000_timer_interrupt(int irq, void *dev_id)
>  {
>  	/* clear timer 1 */
>  	ixp2000_reg_wrb(IXP2000_T1_CLR, 1);
what do you think about this patch?  It's (IMHO) trivial and fixes a
long standing build warning.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/