linux-kernel - Re: [PATCH 2/2] Staging: comedi: fix bracing and 80 character stylein ni_at_a2150.c This is a patch to the ni_at_a2150.c file to fix up bracing and 80 character warnings found by the checkpatch.pl tool Signed-off-by: Graham M Howe <gman.1352@...glemail.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201002130007.38863.oliver@neukum.org>
Date:	Sat, 13 Feb 2010 00:07:38 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	Graham M Howe <gman.1352@...glemail.com>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: fix bracing and 80 character stylein ni_at_a2150.c This is a patch to the ni_at_a2150.c file to fix up bracing and 80 character warnings  found by the checkpatch.pl tool Signed-off-by: Graham M Howe <gman.1352@...glemail.com>

Am Samstag, 13. Februar 2010 00:05:37 schrieb Graham M Howe:
> --- a/drivers/staging/comedi/drivers/ni_at_a2150.c
> +++ b/drivers/staging/comedi/drivers/ni_at_a2150.c
> @@ -86,8 +86,10 @@ TRIG_WAKE_EOS
>  #define   CLOCK_SELECT_BITS(x)         (((x) & 0x3) << 3)
>  #define   CLOCK_DIVISOR_BITS(x)                (((x) & 0x3) << 5)
>  #define   CLOCK_MASK           (0xf << 3)
> -#define   ENABLE0_BIT          0x80    /*  enable (don't internally ground) channels 0 and 1 */
> -#define   ENABLE1_BIT          0x100   /*  enable (don't internally ground) channels 2 and 3 */
> +/*  enable (don't internally ground) channels 0 and 1 */
> +#define   ENABLE0_BIT          0x80
> +/*  enable (don't internally ground) channels 2 and 3 */

Does this really improve readability?

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/