linux-kernel - Re: [BUGFIX][PATCH] memcg: fix oom killing a child process in an other cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100212114133.57bb1141.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Fri, 12 Feb 2010 11:41:33 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Minchan Kim <minchan.kim@...il.com>
Cc:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, stable@...nel.org,
	rientjes@...gle.com,
	"balbir@...ux.vnet.ibm.com" <balbir@...ux.vnet.ibm.com>,
	"nishimura@....nes.nec.co.jp" <nishimura@....nes.nec.co.jp>
Subject: Re: [BUGFIX][PATCH] memcg: fix oom killing a child process in an 
 other cgroup

On Fri, 12 Feb 2010 11:39:35 +0900
Minchan Kim <minchan.kim@...il.com> wrote:

> On Fri, Feb 12, 2010 at 10:53 AM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@...fujitsu.com> wrote:
> > This patch itself is againt mmotm-Feb10 but can be applied to 2.6.32.8
> > without problem.
> >
> > ==
> > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> >
> > Now, oom-killer is memcg aware and it finds the worst process from
> > processes under memcg(s) in oom. Then, it kills victim's child at first.
> > It may kill a child in other cgroup and may not be any help for recovery.
> > And it will break the assumption users have...
> >
> > This patch fixes it.
> >
> > CC: stable@...nel.org
> > CC: Minchan Kim <minchan.kim@...il.com>
> > CC: Balbir Singh <balbir@...ux.vnet.ibm.com>
> > CC: Daisuke Nishimura <nishimura@....nes.nec.co.jp>
> > Acked-by: David Rientjes <rientjes@...gle.com>
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> Reviewed-by: Minchan Kim <minchan.kim@...il.com>
> 
> Sorry for noise, Kame.
> 
No problem. You give me a chance to consider other problems/dirtiness of codes.
I continue review to make memcg cleaer.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/