lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 Feb 2010 21:23:27 +0530 From: Rabin Vincent <rabin@....in> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Steven Rostedt <rostedt@...dmis.org>, Frederic Weisbecker <fweisbec@...il.com>, Ingo Molnar <mingo@...hat.com>, Abhishek Sagar <sagar.abhishek@...il.com> Subject: Re: [PATCH 08/10] ARM: ftrace: fix and update dynamic ftrace On Sun, Feb 14, 2010 at 12:08:40PM +0100, Uwe Kleine-König wrote: > > diff --git a/arch/arm/include/asm/ftrace.h b/arch/arm/include/asm/ftrace.h > > index 103f7ee..4a56a2e 100644 > > --- a/arch/arm/include/asm/ftrace.h > > +++ b/arch/arm/include/asm/ftrace.h > > @@ -2,12 +2,29 @@ > > #define _ASM_ARM_FTRACE > > > > #ifdef CONFIG_FUNCTION_TRACER > > -#define MCOUNT_ADDR ((long)(mcount)) > > +#define MCOUNT_ADDR ((unsigned long)(__gnu_mcount_nc)) > hhmm, does this work with both the old and the new mcount function? Yes, MCOUNT_ADDR is not used by the generic ftrace code directly, but is instead only passed to our arch specific functions. We determine the right mcount address to use there: > +#define OLD_MCOUNT_ADDR ((unsigned long) mcount) [..] > +static unsigned long adjust_address(struct dyn_ftrace *rec, unsigned long addr) > +{ > + if (!rec->arch.old_mcount) > + return addr; > + > + if (addr == MCOUNT_ADDR) > + addr = OLD_MCOUNT_ADDR; > + else if (addr == FTRACE_ADDR) > + addr = OLD_FTRACE_ADDR; > + > + return addr; > +} I changed MCOUNT_ADDR from mcount to __gnu_mcount_nc because we always build __gnu_mcount_nc in, but don't build mcount when using Thumb-2. Rabin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists