| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <69e28c911002141401q3ca8810djc5f1775dfd0d6f3@mail.gmail.com> Date: Sun, 14 Feb 2010 23:01:25 +0100 From: Gábor Stefanik <netrolller.3d@...il.com> To: Alessandro Ghedini <al3xbio@...il.com> Cc: gregkh@...e.de, jmm@...ian.org, mithlesh@...syssoft.com, karllinuxtest.relton@...world.com, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] Staging: wlan-ng: fix most of the style issues in hfa384x.h You posted the wrong patch - this is only an interdiff. Also, it might be a good idea to reduce the spacing for all entries, not just these "overdone" ones, to keep them lined-up nicely. On Sun, Feb 14, 2010 at 9:12 PM, Alessandro Ghedini <al3xbio@...il.com> wrote: > This patch fixes all the errors and the majority of the warnings found with > checkpatch.pl script in hfa384x.h, following Gábor Stefanik hints > > Signed-off-by: Alessandro Ghedini <al3xbio@...il.com> > --- > drivers/staging/wlan-ng/hfa384x.h | 10 ++-------- > 1 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h > index 8e39f76..3d440f8 100644 > --- a/drivers/staging/wlan-ng/hfa384x.h > +++ b/drivers/staging/wlan-ng/hfa384x.h > @@ -63,15 +63,9 @@ > /*--- Mins & Maxs -----------------------------------*/ > #define HFA384x_PORTID_MAX ((u16)7) > #define HFA384x_NUMPORTS_MAX ((u16)(HFA384x_PORTID_MAX+1)) > -#define HFA384x_PDR_LEN_MAX ((u16)512) /* > - * in bytes, > - * from EK > - */ > +#define HFA384x_PDR_LEN_MAX ((u16)512) /* in bytes, from EK */ > #define HFA384x_PDA_RECS_MAX ((u16)200) /* a guess */ > -#define HFA384x_PDA_LEN_MAX ((u16)1024) /* > - * in bytes, > - * from EK > - */ > +#define HFA384x_PDA_LEN_MAX ((u16)1024) /* in bytes, from EK*/ > #define HFA384x_SCANRESULT_MAX ((u16)31) > #define HFA384x_HSCANRESULT_MAX ((u16)31) > #define HFA384x_CHINFORESULT_MAX ((u16)16) > -- > 1.6.6.2 > > _______________________________________________ > devel mailing list > devel@...uxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/devel > -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists