linux-kernel - [patch/rfc] Make poll/select report error (POLLNVAL and EBADF) for unsupported files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1002141403240.18795@makko.or.mcafeemobile.com>
Date:	Sun, 14 Feb 2010 14:27:44 -0800 (PST)
From:	Davide Libenzi <davidel@...ilserver.org>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
cc:	Andrew Morton <akpm@...ux-foundation.org>, stephane.thiell@....fr
Subject: [patch/rfc] Make poll/select report error (POLLNVAL and EBADF) for
 unsupported files

Currently poll and select consider a non poll-supported file as one with 
full event mask set, instead of reporting proper error to the caller.
This behavior can fool the caller of proper functionality being returned, 
while instead no valid event was processed/read from the device.
This came out linked to this bug report:

http://bugzilla.kernel.org/show_bug.cgi?id=15272

IMHO, it'd be more adequate to report proper error code, for files that do 
not support f_op->poll(), but then I am also not sure how much breakage 
can this bring to existing (already broken "in just the right way") 
applications.
Untested, discussion-only, patch.


Signed-off-by: Davide Libenzi <davidel@...ilserver.org>


- Davide


---
 fs/select.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

Index: linux-2.6.mod/fs/select.c
===================================================================
--- linux-2.6.mod.orig/fs/select.c	2010-02-14 14:06:12.000000000 -0800
+++ linux-2.6.mod/fs/select.c	2010-02-14 14:16:09.000000000 -0800
@@ -447,12 +447,13 @@ int do_select(int n, fd_set_bits *fds, s
 					continue;
 				file = fget_light(i, &fput_needed);
 				if (file) {
-					f_op = file->f_op;
-					mask = DEFAULT_POLLMASK;
-					if (f_op && f_op->poll) {
-						wait_key_set(wait, in, out, bit);
-						mask = (*f_op->poll)(file, wait);
+					if (unlikely((f_op = file->f_op) == NULL ||
+						     f_op->poll == NULL)) {
+						retval = -EBADF;
+						goto error_exit;
 					}
+					wait_key_set(wait, in, out, bit);
+					mask = (*f_op->poll)(file, wait);
 					fput_light(file, fput_needed);
 					if ((mask & POLLIN_SET) && (in & bit)) {
 						res_in |= bit;
@@ -501,7 +502,7 @@ int do_select(int n, fd_set_bits *fds, s
 					   to, slack))
 			timed_out = 1;
 	}
-
+error_exit:
 	poll_freewait(&table);
 
 	return retval;
@@ -720,15 +721,14 @@ static inline unsigned int do_pollfd(str
 		file = fget_light(fd, &fput_needed);
 		mask = POLLNVAL;
 		if (file != NULL) {
-			mask = DEFAULT_POLLMASK;
 			if (file->f_op && file->f_op->poll) {
 				if (pwait)
 					pwait->key = pollfd->events |
 							POLLERR | POLLHUP;
 				mask = file->f_op->poll(file, pwait);
+				/* Mask out unneeded events. */
+				mask &= pollfd->events | POLLERR | POLLHUP;
 			}
-			/* Mask out unneeded events. */
-			mask &= pollfd->events | POLLERR | POLLHUP;
 			fput_light(file, fput_needed);
 		}
 	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/