[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <m1eikmbqz1.fsf@fess.ebiederm.org>
Date: Mon, 15 Feb 2010 04:53:06 -0800
From: ebiederm@...ssion.com (Eric W. Biederman)
To: Américo Wang <xiyou.wangcong@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...e.de>,
"Tejun Heo \<tj\@kernel.org\> Neil Brown" <neilb@...e.de>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] sysfs: Use sysfs_attr_init and sysfs_bin_attr_init on dynamic attributes
Américo Wang <xiyou.wangcong@...il.com> writes:
> On Thu, Feb 11, 2010 at 03:23:05PM -0800, Eric W. Biederman wrote:
>>
>>These are the non-static sysfs attributes that exist on
>>my test machine. Fix them to use sysfs_attr_init or
>>sysfs_bin_attr_init as appropriate. It simply requires
>>making a sysfs attribute present to see this. So this
>>is a little bit tedious but otherwise not too bad.
>>
>>Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
>
>
> Based on previous patches,
>
> Acked-by: WANG Cong <xiyou.wangcong@...il.com>
>
> But it seems there are still some cases missed, e.g. the one
> reported by John. We can fix them when they appear.
Yes. There is at least the module case that I sent a follow up
patch for.
Whacking these things when the appear isn't my favorite policy
but at least it is easy.
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists