linux-kernel - Re: [PATCH] fs: Add flags to __d_path for suppressing suffix and mapping /proc/self

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100215162338.GB4905@x200>
Date:	Mon, 15 Feb 2010 18:23:38 +0200
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	viro@...IV.linux.org.uk, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: Add flags to __d_path for suppressing suffix and
 mapping /proc/self

On Mon, Feb 15, 2010 at 11:15:23AM -0500, Christoph Hellwig wrote:
> On Mon, Feb 15, 2010 at 11:11:37PM +0900, Tetsuo Handa wrote:
> > This patch allows __d_path() to
> > (1) suppress " (deleted)" suffix if dentry was already deleted
> 
> This part looks fine to me.

Not to me. It should be

	__d_path(... int *deleted)

and caller decides what to do with deleted files.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/