linux-kernel - Re: linux-next: Tree for February 15 (staging/dt3155)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B797A5C.8020306@oracle.com>
Date:	Mon, 15 Feb 2010 08:46:20 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org, Greg KH <gregkh@...e.de>
Subject: Re: linux-next: Tree for February 15 (staging/dt3155)

On 02/15/10 00:49, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20100212:


1/  dt3155 tries to use arbitrary divide & modulus.  This fails on i386:

ERROR: "__udivdi3" [drivers/staging/dt3155/dt3155.ko] undefined!
ERROR: "__umoddi3" [drivers/staging/dt3155/dt3155.ko] undefined!

2/  since DT3155 depends on PCI, these lines can be dropped from dt3155_drv.c:

-#ifndef CONFIG_PCI
-#error  "DT3155 :  Kernel PCI support not enabled (DT3155 drive requires PCI)"
-#endif

3/  header files need to be included even when built-in instead of defined(MODULE)
to eliminate build errors:

drivers/staging/dt3155/dt3155_drv.c:1047: error: implicit declaration of function 'request_irq'
drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_SHARED' undeclared (first use in this function)
drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_DISABLED' undeclared (first use in this function)
drivers/staging/dt3155/dt3155_drv.c:1091: error: implicit declaration of function 'free_irq'


-#ifdef MODULE
 #include <linux/module.h>
 #include <linux/interrupt.h>
 
 
 MODULE_LICENSE("GPL");
 
-#endif


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/