linux-kernel - Re: bug list: range checking issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1002161201140.28127@eeebox2.perex-int.cz>
Date:	Tue, 16 Feb 2010 12:02:56 +0100 (CET)
From:	Jaroslav Kysela <perex@...ex.cz>
To:	Clemens Ladisch <clemens@...isch.de>
cc:	Dan Carpenter <error27@...il.com>, kernel-janitors@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, Takashi Iwai <tiwai@...e.de>
Subject: Re: bug list: range checking issues

On Tue, 16 Feb 2010, Clemens Ladisch wrote:

> This looks correct; the channels parameter is an interval, not a mask.
>
> 	if (!params->fifo_size) {
> 		if (snd_mask_min(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT]) ==
> 		    snd_mask_max(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT]) &&
> 		    snd_mask_min(&params->masks[SNDRV_PCM_HW_PARAM_CHANNELS]) ==
> 		    snd_mask_max(&params->masks[SNDRV_PCM_HW_PARAM_CHANNELS])) {
>
> Jaroslav, I guess this should have been snd_interval_min/max?
> And shouldn't the parameters be accessed with hw_param_mask/interval?

Yes, the checks are not valid. Thanks for this notice. I fixed this issue 
in this commit:

http://git.alsa-project.org/?p=alsa-kernel.git;a=commitdiff;h=3be522a9514f58e0596db34898a514df206cadc5

 					Jaroslav

-----
Jaroslav Kysela <perex@...ex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/