linux-kernel - Re: [PATCH 3/3] x86: ELF_PLAT_INIT() shouldn't worry about TIF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100216142401.GA18671@redhat.com>
Date:	Tue, 16 Feb 2010 15:24:01 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Roland McGrath <roland@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] x86: ELF_PLAT_INIT() shouldn't worry about TIF_IA32

On 02/16, Oleg Nesterov wrote:
>
>  #define ELF_PLAT_INIT(_r, load_addr)			\
> -do {							\
> -	elf_common_init(&current->thread, _r, 0);	\
> -	clear_thread_flag(TIF_IA32);			\
> -} while (0)
> +	elf_common_init(&current->thread, _r, 0);
                                                ^
unneeded semicolon, sorry...

------------------------------------------------------------------------------
[PATCH 3/3] x86: ELF_PLAT_INIT() shouldn't worry about TIF_IA32

64bit vesrion of ELF_PLAT_INIT() clears TIF_IA32, but at this point it
must be already cleared by SET_PERSONALITY == set_personality_64bit.

Signed-off-by: Oleg Nesterov <oleg@...hat.com>
---

 arch/x86/include/asm/elf.h |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- exec/arch/x86/include/asm/elf.h~3_ELF_PLAT_INIT_IA32	2010-01-31 13:57:24.000000000 +0100
+++ exec/arch/x86/include/asm/elf.h	2010-02-16 15:19:43.000000000 +0100
@@ -170,10 +170,7 @@ static inline void elf_common_init(struc
 }
 
 #define ELF_PLAT_INIT(_r, load_addr)			\
-do {							\
-	elf_common_init(&current->thread, _r, 0);	\
-	clear_thread_flag(TIF_IA32);			\
-} while (0)
+	elf_common_init(&current->thread, _r, 0)
 
 #define	COMPAT_ELF_PLAT_INIT(regs, load_addr)		\
 	elf_common_init(&current->thread, regs, __USER_DS)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/